enh: filter_read also takes Option<&Alignment> #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentp
force-pushed
the
read_filter_alignment
branch
2 times, most recently
from
f20fa89
to
8f8e4bc
Compare
brentp
force-pushed
the
read_filter_alignment
branch
from
8f8e4bc
to
476c1c6
Compare
Closed
|
Any chance you have the benchmarks you ran on the PR are available to check on this one? I don't see any reason to suspect that this would slow things down, just being cautious since I haven't touched this code in a long time. |
|
Sorry for the delay. I just built a release for main and my branch and ran a few times and the times are nearly identical. |
sstadick
approved these changes
Jun 20, 2023
|
See release v0.9.0 which should land on crates.io shortly. |
|
And thanks for the PR! |
|
Thanks Seth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #60
This seems to be the smallest change and makes it possible for
only_depthto work with minimal changes since that doesn't actually use the htslib pileup stuff.